Surya Hebbar has posted comments on this change. (
http://gerrit.cloudera.org:8080/21970 )
Change subject: IMPALA-13473: Add support for JS code analysis and linting with
ESLint
......................................................................
Patch Set 6:
(1 comment)
To ensure quicker run times for the jenkins job, NodeJS tarball is cached
within "${HOME}/.cache" directory, after the initial installation.
ESLint's packages and dependencies have been made to be cached, using NPM's own
package management and are also cached locally.
The required linting packages have been added as dependencies in the
"www/scripts" directory.
All the test scripts and related dependencies have been moved to -
$IMPALA_HOME/tests/webui/js_tests.
All the custom ESLint formatter scripts and related dependencies have been
moved to -
$IMPALA_HOME/tests/webui/linting.
A combination of NodeJS's 'prefix' argument and NODE_PATH environmentalvariable
is being used to seperate the dependencies and webUI scripts. To support
running the tests from a remote directory(i.e. tests/webui), by modifying the
required base paths.
http://gerrit.cloudera.org:8080/#/c/21970/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21970/5//COMMIT_MSG@35
PS5, Line 35:
> Ack. I will move these into the appropriate directory.
Done
--
To view, visit http://gerrit.cloudera.org:8080/21970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb3d0a9221738e2ac6fefd60087eaeee4366e33f
Gerrit-Change-Number: 21970
Gerrit-PatchSet: 6
Gerrit-Owner: Surya Hebbar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Surya Hebbar <[email protected]>
Gerrit-Comment-Date: Thu, 05 Dec 2024 13:06:18 +0000
Gerrit-HasComments: Yes
