Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21970 )
Change subject: IMPALA-13473: Add support for JS code analysis and linting with ESLint ...................................................................... Patch Set 4: I made some deliberate changes to break ESLint rules within the 2 JS files, in order to trigger comments from the test jenkins job. It has successfully resulted with the above 2 comments in the JS files. NodeJS/ESLint installation and these linting checks are only performed if there are any ".js" files among the changed files. In other cases, only flake8 and miscellaneous checks run as usual, without any change in efficiency. NodeJS is already being downloaded from IMPALA_TOOLCHAIN_HOST, thanks to IMPALA-13146. Still, I think for gerrit-auto-critic there might be a need to cache nodejs installation within jenkins, just like how flake8 and other dependent packages are being cached within pip's ".cache" directory. -- To view, visit http://gerrit.cloudera.org:8080/21970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb3d0a9221738e2ac6fefd60087eaeee4366e33f Gerrit-Change-Number: 21970 Gerrit-PatchSet: 4 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 06 Nov 2024 20:05:15 +0000 Gerrit-HasComments: No
