Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21970 )
Change subject: IMPALA-13473: Add support for JS code analysis and linting with ESLint ...................................................................... Patch Set 5: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21970/5/www/scripts/eslint.config.js File www/scripts/eslint.config.js: http://gerrit.cloudera.org:8080/#/c/21970/5/www/scripts/eslint.config.js@27 PS5, Line 27: "no-unused-vars": "warn", Missing space after key 'no-unused-vars'. http://gerrit.cloudera.org:8080/#/c/21970/5/www/scripts/eslint/eslint_custom_output_formatter.js File www/scripts/eslint/eslint_custom_output_formatter.js: http://gerrit.cloudera.org:8080/#/c/21970/5/www/scripts/eslint/eslint_custom_output_formatter.js@18 PS5, Line 18: import path from 'path'; Strings must use doublequote. -- To view, visit http://gerrit.cloudera.org:8080/21970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb3d0a9221738e2ac6fefd60087eaeee4366e33f Gerrit-Change-Number: 21970 Gerrit-PatchSet: 5 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 06 Nov 2024 20:56:32 +0000 Gerrit-HasComments: Yes
