Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21683 )
Change subject: IMPALA-13304: Include aggregate instance-level metrics within experimental profile(V2) ...................................................................... Patch Set 8: Sorry, I had pushed the previous draft some days ago without staging the changes, so on deletion, the previous comment also got deleted. For supporting the query timeline display for the experimental profile, the info string "Table Name" was also required to be added to the aggregated profile's info strings. I tried to include info strings in different ways, while keeping in mind(IMPALA-9846), but too many changes were required to completely separate info strings and related methods between aggregated and the root profile. So, after rolling back, I implemented it in this form. Please let me know, if I should include the info strings in a different way or change the representation. -- To view, visit http://gerrit.cloudera.org:8080/21683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49e18a7a7e1288e3e674e15b6fc86aad60a08214 Gerrit-Change-Number: 21683 Gerrit-PatchSet: 8 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Fri, 15 Nov 2024 21:01:10 +0000 Gerrit-HasComments: No
