Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21955 )
Change subject: IMPALA-13465: Trace TupleId further to reduce Agg cardinality ...................................................................... Patch Set 17: (2 comments) http://gerrit.cloudera.org:8080/#/c/21955/15/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/21955/15/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@458 PS15, Line 458: producerNode.capCardinalityAtLimit(producerNode.getInputCardinality()); : } > While working on IMPALA-13526, I notice case where producerCardinality=-1. Fixed to handle unknown cardinality (-1) properly. http://gerrit.cloudera.org:8080/#/c/21955/16/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/21955/16/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@420 PS16, Line 420: List<Expr> exprs = entry.getValue(); : if (exprs.size() <= 1) { : // Move single expression to exprsWithUniqueTupleId. : exprsWithUniqueTupleId.addAll(exprs); : continue; : } : > This should be lazily loaded ONLY IF we get to L434. Done -- To view, visit http://gerrit.cloudera.org:8080/21955 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11f59ccc469c24c1800abaad3774c56190306944 Gerrit-Change-Number: 21955 Gerrit-PatchSet: 17 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 08 Nov 2024 20:12:27 +0000 Gerrit-HasComments: Yes
