Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21955 )
Change subject: IMPALA-13465: Trace TupleId further to reduce Agg cardinality ...................................................................... Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/21955/16/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/21955/16/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@420 PS16, Line 420: planNode.postAccept(node -> { : if (node instanceof ScanNode || node instanceof UnionNode) { : PlanNode pNode = (PlanNode) node; : for (TupleId tupleId : pNode.tupleIds_) : producerNodes.putIfAbsent(tupleId, pNode); : } : }); This should be lazily loaded ONLY IF we get to L434. -- To view, visit http://gerrit.cloudera.org:8080/21955 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11f59ccc469c24c1800abaad3774c56190306944 Gerrit-Change-Number: 21955 Gerrit-PatchSet: 16 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 08 Nov 2024 01:41:34 +0000 Gerrit-HasComments: Yes
