Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21955 )
Change subject: IMPALA-13465: Trace TupleId further to reduce Agg cardinality ...................................................................... Patch Set 15: (3 comments) I will rebase this patch and stack IMPALA-13086 patch on top of it. http://gerrit.cloudera.org:8080/#/c/21955/15/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/21955/15/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@324 PS15, Line 324: private static @Nullable TupleId Returning TupleDescriptor can help solving IMPALA-13086 later because several maps in HdfsScanNode is keyed by TupleDescriptor class. http://gerrit.cloudera.org:8080/#/c/21955/15/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@432 PS15, Line 432: final List<PlanNode> producerNodes = Lists.newArrayList(); Turn this into Map<TupleId, PlanNode> to simplify loop below. http://gerrit.cloudera.org:8080/#/c/21955/15/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@458 PS15, Line 458: long numGroupFromCommonTuple = : Math.min(producerCardinality, ndvBasedNumGroup); If producerCardinality == 0, numGroupFromCommonTuple must be equals to 1. -- To view, visit http://gerrit.cloudera.org:8080/21955 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11f59ccc469c24c1800abaad3774c56190306944 Gerrit-Change-Number: 21955 Gerrit-PatchSet: 15 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 05 Nov 2024 20:06:27 +0000 Gerrit-HasComments: Yes
