Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22029 )
Change subject: IMPALA-13511: Calcite planner: support sub-second datetime parts ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22029/1/java/calcite-planner/src/main/codegen/templates/Parser.jj File java/calcite-planner/src/main/codegen/templates/Parser.jj: http://gerrit.cloudera.org:8080/#/c/22029/1/java/calcite-planner/src/main/codegen/templates/Parser.jj@7541 PS1, Line 7541: | <MICROSECOND> : | <MILLISECOND> > For my own understanding: We need these lines because millisecond, microsec So I tried removing millisecond and it still ran fine. So I'm not sure. I took a few seconds to look at Parser.jj, didn't spend a lot of time. It differentiates "FunctionName" from "CompoundIdentifier". I'm guessing a CompounddIdentifier is something with a "." in it? Maybe there are issues with function names used as table columns and differentiating it from a <db>.<udf>? Not sure. We don't support UDFs yet either, so I'm not sure I can test this right now. My initial reason for putting this here was because SECOND, MINUTE, and other timestamp functions are here. I did it kind of blindly and for consistency. Sigh, and then I missed NANOSECOND on this commit (I do have it in my branch, not sure why it's missed here). Do you think I should try to be consistent here and add NANOSECOND? Or just remove it because it's unproven functionality? -- To view, visit http://gerrit.cloudera.org:8080/22029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I392c3900c70e7754a35ef25fc720ba4a2f2e5dd6 Gerrit-Change-Number: 22029 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 07 Nov 2024 14:50:59 +0000 Gerrit-HasComments: Yes
