Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22029 )
Change subject: IMPALA-13511: Calcite planner: support sub-second datetime parts ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22029/1/java/calcite-planner/src/main/codegen/templates/Parser.jj File java/calcite-planner/src/main/codegen/templates/Parser.jj: http://gerrit.cloudera.org:8080/#/c/22029/1/java/calcite-planner/src/main/codegen/templates/Parser.jj@7541 PS1, Line 7541: | <MICROSECOND> : | <MILLISECOND> > So I tried removing millisecond and it still ran fine. So I'm not sure. We have millisecond, microsecond, and nanosecond listed in config.fmpp for "nonReservedKeywords". I think that must be why this works. If I remove "second" from this list, this SQL fails: select second('09:10:11'); But if I then add "second" to the "nonReservedKeywords", it starts to work again. https://github.com/apache/impala/blob/master/java/calcite-planner/src/main/codegen/config.fmpp#L183 So, I think we can skip adding these new entries because they are already on the nonReservedKeywords list? -- To view, visit http://gerrit.cloudera.org:8080/22029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I392c3900c70e7754a35ef25fc720ba4a2f2e5dd6 Gerrit-Change-Number: 22029 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 08 Nov 2024 21:09:18 +0000 Gerrit-HasComments: Yes
