Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22029 )
Change subject: IMPALA-13511: Calcite planner: support sub-second datetime parts ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22029/1/java/calcite-planner/src/main/codegen/templates/Parser.jj File java/calcite-planner/src/main/codegen/templates/Parser.jj: http://gerrit.cloudera.org:8080/#/c/22029/1/java/calcite-planner/src/main/codegen/templates/Parser.jj@7541 PS1, Line 7541: | <MICROSECOND> : | <MILLISECOND> For my own understanding: We need these lines because millisecond, microsecond, and nanosecond are reserved words. Impala has a function called "millisecond" and it wouldn't work if it wasn't listed here? Is that right? (From what I can tell, Impala doesn't not have a "microsecond" or "nanosecond" functions, but I'm not sure why not.) -- To view, visit http://gerrit.cloudera.org:8080/22029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I392c3900c70e7754a35ef25fc720ba4a2f2e5dd6 Gerrit-Change-Number: 22029 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 06 Nov 2024 23:11:50 +0000 Gerrit-HasComments: Yes
