Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22014 )
Change subject: IMPALA-13154: Update stats when loading an HDFS table ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/22014/7/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/22014/7/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@363 PS7, Line 363: public FileMetadataStats() { : init(); : } : : public FileMetadataStats(boolean init) { : if (init) { : init(); : } else { : unset(); : } : } : : // Unsets the storage stats to indicate that their values are unknown. : public void unset() { : numFiles = -1; : numBlocks = -1; : totalFileBytes = -1; : } > I notice that some HdfsPartition constructors do not have FileMetadataStats > in their parameter lists. I think we can set fileMetadataStats_ to null in those constructors. Their callers currently don't use the new getFileMetadataStats() method we just added in this patch. If they want to use it, they should use the correct constructor. -- To view, visit http://gerrit.cloudera.org:8080/22014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e2eb503b0f61b1e6403058bc5dc78d721e7e940 Gerrit-Change-Number: 22014 Gerrit-PatchSet: 8 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Wed, 06 Nov 2024 09:40:49 +0000 Gerrit-HasComments: Yes
