Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/22014 )
Change subject: IMPALA-13154: Update stats when loading an HDFS table ...................................................................... Patch Set 7: (5 comments) > Patch Set 4: > > (1 comment) Thanks for reviewing! http://gerrit.cloudera.org:8080/#/c/22014/4/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/22014/4/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@1626 PS4, Line 1626: public Builder setFileDescriptors(ImmutableList<byte[]> encodedDescriptors) { : encodedFileDescriptors_ = encodedDescriptors; : return this; : } > To avoid duplicate codes, I think we can extract these into a method, e.g. Thanks! Changed. http://gerrit.cloudera.org:8080/#/c/22014/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/22014/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2484 PS4, Line 2484: for (FileDescriptor fd: filteredFds) { : thriftFds.add(fd.toThrift()); : } : return numFilesFiltered; > This is stale after IMPALA-8667. Can we remove it by the way? Thanks! Removed. http://gerrit.cloudera.org:8080/#/c/22014/4/tests/custom_cluster/test_web_pages.py File tests/custom_cluster/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/22014/4/tests/custom_cluster/test_web_pages.py@38 PS4, Line 38: class TestWebPage(CustomClusterTestSuite): > Maybe we can use get_debug_page() directly: Thanks! Changed. http://gerrit.cloudera.org:8080/#/c/22014/4/tests/custom_cluster/test_web_pages.py@514 PS4, Line 514: table_list = response_json[list_name] > In case this feature is broken in local catalog mode in the future, we'd be Thanks! Added a new test case for local catalog mode. http://gerrit.cloudera.org:8080/#/c/22014/4/tests/custom_cluster/test_web_pages.py@540 PS4, Line 540: impalad_args="--use_local_catalog=true") > Please ignore checking the precise value of estimated memory. It's calculat Thanks! Added checks for the values. -- To view, visit http://gerrit.cloudera.org:8080/22014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e2eb503b0f61b1e6403058bc5dc78d721e7e940 Gerrit-Change-Number: 22014 Gerrit-PatchSet: 7 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Wed, 06 Nov 2024 07:25:20 +0000 Gerrit-HasComments: Yes
