Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22014 )
Change subject: IMPALA-13154: Update stats when loading an HDFS table ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/22014/7/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/22014/7/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@363 PS7, Line 363: public FileMetadataStats() { : init(); : } : : public FileMetadataStats(boolean init) { : if (init) { : init(); : } else { : unset(); : } : } : : // Unsets the storage stats to indicate that their values are unknown. : public void unset() { : numFiles = -1; : numBlocks = -1; : totalFileBytes = -1; : } It seems we don't need the unset() method anymore. Previously it's only used in HdfsTable#load() and it's now replaced with updateStatistics(): https://github.com/apache/impala/blob/88e0e4e8baa97f7fded12230b14232dc85cf6d79/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java#L1352 If we can remove unset(), the constructors can be much simpler. http://gerrit.cloudera.org:8080/#/c/22014/7/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1261 PS7, Line 1261: partitionStats nit: we can use partition.getFileMetadataStats() directly -- To view, visit http://gerrit.cloudera.org:8080/22014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e2eb503b0f61b1e6403058bc5dc78d721e7e940 Gerrit-Change-Number: 22014 Gerrit-PatchSet: 7 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Wed, 06 Nov 2024 07:38:30 +0000 Gerrit-HasComments: Yes
