Hello Aman Sinha, Joe McDonnell, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21987
to look at the new patch set (#2).
Change subject: IMPALA-13493: Square brackets failing in Calcite planner.
......................................................................
IMPALA-13493: Square brackets failing in Calcite planner.
Needed to change the parser to allow hints that have square
brackets. These hints are not being used at the current time,
but it will now compile.
Specifically, this was found when testing the following query
with the shuffle hint (in distinct.test):
select count(distinct a.int_col) from functional.alltypes a
inner join [shuffle] functional.alltypes b on
a.int_col = b.int_col;
To minimize the changes made in the parser file, the
BRACKET_QUOTED_IDENTIFIER was reused, but removed from
the part in the parser where it was actually used as an
identifier. It is simply parsed and ignored when following
a join type.
Change-Id: I201a6cecfa1af4af6fd2739904f624b8eb790308
---
M java/calcite-planner/src/main/codegen/templates/Parser.jj
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/21987/2
--
To view, visit http://gerrit.cloudera.org:8080/21987
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I201a6cecfa1af4af6fd2739904f624b8eb790308
Gerrit-Change-Number: 21987
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
