Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21987 )
Change subject: IMPALA-13493: Square brackets failing in Calcite planner. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21987/1/java/calcite-planner/src/main/codegen/templates/Parser.jj File java/calcite-planner/src/main/codegen/templates/Parser.jj: http://gerrit.cloudera.org:8080/#/c/21987/1/java/calcite-planner/src/main/codegen/templates/Parser.jj@5337 PS1, Line 5337: /* > I was going back and forth on this. In https://gerrit.cloudera.org/c/21923/4/java/calcite-planner/src/main/codegen/templates/Parser.jj you deleted a bunch. I think we err on not leaving commented-out code around. -- To view, visit http://gerrit.cloudera.org:8080/21987 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I201a6cecfa1af4af6fd2739904f624b8eb790308 Gerrit-Change-Number: 21987 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 29 Oct 2024 21:02:01 +0000 Gerrit-HasComments: Yes
