Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21987 )
Change subject: IMPALA-13493: Square brackets failing in Calcite planner. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21987/1/java/calcite-planner/src/main/codegen/templates/Parser.jj File java/calcite-planner/src/main/codegen/templates/Parser.jj: http://gerrit.cloudera.org:8080/#/c/21987/1/java/calcite-planner/src/main/codegen/templates/Parser.jj@2004 PS1, Line 2004: ) [<BRACKET_QUOTED_IDENTIFIER>] > Can you explain a bit more how this works? The syntax is obscure. Maybe pro Done http://gerrit.cloudera.org:8080/#/c/21987/1/java/calcite-planner/src/main/codegen/templates/Parser.jj@5337 PS1, Line 5337: /* > Why is this commented out rather than deleted? I was going back and forth on this. I think it's a good idea to track how this differs from the original Parser.jj file. Commenting things out rather than removing code keeps the original code close at hand. I don't mind deleting it though if we feel that is the correct thing to do. -- To view, visit http://gerrit.cloudera.org:8080/21987 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I201a6cecfa1af4af6fd2739904f624b8eb790308 Gerrit-Change-Number: 21987 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 29 Oct 2024 21:01:16 +0000 Gerrit-HasComments: Yes
