Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20494 )
Change subject: IMPALA-12390 (part 4): Enable unnecessary-value-param ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/20494/11/be/src/benchmarks/lock-benchmark.cc File be/src/benchmarks/lock-benchmark.cc: http://gerrit.cloudera.org:8080/#/c/20494/11/be/src/benchmarks/lock-benchmark.cc@154 PS11, Line 154: new thread(consume_fn, num_per_consumer, &data->value)); > This isn't right, this would do multiple moves on the same source. Done -- To view, visit http://gerrit.cloudera.org:8080/20494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8aa5d98596d82f615a0a728e0235e7dd9d8b5003 Gerrit-Change-Number: 20494 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Mon, 28 Oct 2024 21:45:38 +0000 Gerrit-HasComments: Yes
