Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20494 )
Change subject: IMPALA-12390 (part 4): Enable unnecessary-value-param ...................................................................... Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/20494/13/be/src/transport/TSaslTransport.cpp File be/src/transport/TSaslTransport.cpp: http://gerrit.cloudera.org:8080/#/c/20494/13/be/src/transport/TSaslTransport.cpp@43 PS13, Line 43: memBuf_(new TMemoryBuffer(DEFAULT_MEM_BUF_SIZE, transport->getConfiguration())), Need to update to transport_ http://gerrit.cloudera.org:8080/#/c/20494/13/be/src/transport/TSaslTransport.cpp@53 PS13, Line 53: memBuf_(new TMemoryBuffer(transport->getConfiguration())), Same -- To view, visit http://gerrit.cloudera.org:8080/20494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8aa5d98596d82f615a0a728e0235e7dd9d8b5003 Gerrit-Change-Number: 20494 Gerrit-PatchSet: 13 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Tue, 29 Oct 2024 16:01:54 +0000 Gerrit-HasComments: Yes
