Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20494 )
Change subject: IMPALA-12390 (part 4): Enable unnecessary-value-param ...................................................................... Patch Set 10: (3 comments) I just have 1 nit and few questions. This change is also pretty big and spread around. What is the recommendation if we need to backport to older branch and found a conflict due to absence/presence of this commit? What if the conflict is in the middle of long call path where the whole path is modified by this change? http://gerrit.cloudera.org:8080/#/c/20494/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20494/10//COMMIT_MSG@9 PS10, Line 9: performance-unnecessary-value-param nit: put link in commit message explaining what this is about. https://clang.llvm.org/extra/clang-tidy/checks/performance/unnecessary-value-param.html http://gerrit.cloudera.org:8080/#/c/20494/10//COMMIT_MSG@14 PS10, Line 14: move into place question: I thought std::move is implied by compiler in some obvious case. Does clang-tidy complain about missing std::move? https://stackoverflow.com/questions/9779079/why-does-c11-have-implicit-moves-for-value-parameters-but-not-for-rvalue-para http://gerrit.cloudera.org:8080/#/c/20494/10//COMMIT_MSG@19 PS10, Line 19: cascading changes to other calls. Curious, which call path has the deepest cascading change? -- To view, visit http://gerrit.cloudera.org:8080/20494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8aa5d98596d82f615a0a728e0235e7dd9d8b5003 Gerrit-Change-Number: 20494 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Fri, 25 Oct 2024 21:14:57 +0000 Gerrit-HasComments: Yes
