Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21955 )
Change subject: IMPALA-13465: Trace TupleId further to reduce Agg cardinality ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/21955/7/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/21955/7/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@272 PS7, Line 272: numGroups = estimateNumGroups( : aggInfo.getGroupingExprs(), aggInputCardinality_, preaggNumgroup); > Should remove this. Left over from debugging. Done http://gerrit.cloudera.org:8080/#/c/21955/7/testdata/workloads/functional-planner/queries/PlannerTest/aggregation.test File testdata/workloads/functional-planner/queries/PlannerTest/aggregation.test: http://gerrit.cloudera.org:8080/#/c/21955/7/testdata/workloads/functional-planner/queries/PlannerTest/aggregation.test@1328 PS7, Line 1328: row-size=16B cardinality=600 > This can go as low as 6K, following 00:SCAN HDFS. Done -- To view, visit http://gerrit.cloudera.org:8080/21955 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11f59ccc469c24c1800abaad3774c56190306944 Gerrit-Change-Number: 21955 Gerrit-PatchSet: 8 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 24 Oct 2024 19:58:07 +0000 Gerrit-HasComments: Yes
