Hello Aman Sinha, Yida Wu, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21955
to look at the new patch set (#7).
Change subject: IMPALA-13465: Trace TupleId further to reduce Agg cardinality
......................................................................
IMPALA-13465: Trace TupleId further to reduce Agg cardinality
IMPALA-13405 do tuple analysis to lower AggregationNode cardinality. It
begin focusing on simple column SlotRef, but we can improve this further
to trace the origin TupleId across views and intermediate aggregation
tuple. This patch implement those deeper TupleId tracing to gain further
cardinality reduction. With this deeper TupleId resolution, it is
possible now to narrow down the TupleId search across children ScanNodes
and UnionNodes only.
This patch also fix bug where cardinality estimate of MERGE phase
aggregation is not capped against output cardinality of EXCHANGE node.
Testing:
- Add new test case in agg-node-max-mem-estimate.test.
- Enable cardinality validation in PlannerTest.testAggregation.
- Pass core tests.
Change-Id: I11f59ccc469c24c1800abaad3774c56190306944
---
M fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java
M fe/src/main/java/org/apache/impala/planner/AggregationNode.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
M
testdata/workloads/functional-planner/queries/PlannerTest/agg-node-max-mem-estimate.test
M testdata/workloads/functional-planner/queries/PlannerTest/aggregation.test
M testdata/workloads/functional-planner/queries/PlannerTest/tpch-all.test
M testdata/workloads/functional-planner/queries/PlannerTest/tpch-nested.test
7 files changed, 537 insertions(+), 50 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/21955/7
--
To view, visit http://gerrit.cloudera.org:8080/21955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11f59ccc469c24c1800abaad3774c56190306944
Gerrit-Change-Number: 21955
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
