Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21955 )

Change subject: IMPALA-13465: Trace TupleId further to reduce Agg cardinality
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21955/7/fe/src/main/java/org/apache/impala/planner/AggregationNode.java
File fe/src/main/java/org/apache/impala/planner/AggregationNode.java:

http://gerrit.cloudera.org:8080/#/c/21955/7/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@272
PS7, Line 272: LOG.info("aggInputCardinality_={} prevClass={} numGroups={}",
             :             aggInputCardinality_, 
preaggNode.aggClassNumGroups_.get(aggIdx), numGroups);
Should remove this. Left over from debugging.


http://gerrit.cloudera.org:8080/#/c/21955/7/testdata/workloads/functional-planner/queries/PlannerTest/aggregation.test
File testdata/workloads/functional-planner/queries/PlannerTest/aggregation.test:

http://gerrit.cloudera.org:8080/#/c/21955/7/testdata/workloads/functional-planner/queries/PlannerTest/aggregation.test@1328
PS7, Line 1328: row-size=16B cardinality=9.15K
This can go as low as 6K, following 00:SCAN HDFS.



--
To view, visit http://gerrit.cloudera.org:8080/21955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11f59ccc469c24c1800abaad3774c56190306944
Gerrit-Change-Number: 21955
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Thu, 24 Oct 2024 19:25:40 +0000
Gerrit-HasComments: Yes

Reply via email to