Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21805 )

Change subject: [WIP] IMPALA-12789: Fix unit-test code JdbcDataSourceTest.java
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21805/2/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java:

http://gerrit.cloudera.org:8080/#/c/21805/2/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@798
PS2, Line 798:     if (BackendConfig.INSTANCE != null) {
It looks like we have done something similar for TMP_DIR_PREFIX_LIST. With a 
warning, since this shouldn't appear in production environments.



--
To view, visit http://gerrit.cloudera.org:8080/21805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie07173d256d73c88f5a6c041f087db16b6ff3127
Gerrit-Change-Number: 21805
Gerrit-PatchSet: 2
Gerrit-Owner: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Wed, 23 Oct 2024 00:00:26 +0000
Gerrit-HasComments: Yes

Reply via email to