Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21805 )
Change subject: [WIP] IMPALA-12789: Fix unit-test code JdbcDataSourceTest.java ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21805/2/java/ext-data-source/jdbc/src/test/java/org/apache/impala/extdatasource/jdbc/JdbcDataSourceTest.java File java/ext-data-source/jdbc/src/test/java/org/apache/impala/extdatasource/jdbc/JdbcDataSourceTest.java: http://gerrit.cloudera.org:8080/#/c/21805/2/java/ext-data-source/jdbc/src/test/java/org/apache/impala/extdatasource/jdbc/JdbcDataSourceTest.java@67 PS2, Line 67: private static JdbcDataSource jdbcDataSource_ = new JdbcDataSource(); Ah, this package is the same as the one in fe/, and it loads JdbcDataSource from there. I'm not sure it makes sense to have this test here if it directly depends on fe/ code. Could we move it to that tree? I'm not really sure why ext-data-source is structured like this in general. -- To view, visit http://gerrit.cloudera.org:8080/21805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie07173d256d73c88f5a6c041f087db16b6ff3127 Gerrit-Change-Number: 21805 Gerrit-PatchSet: 2 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 22 Oct 2024 23:54:23 +0000 Gerrit-HasComments: Yes
