Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21805 )
Change subject: [WIP] IMPALA-12789: Fix unit-test code JdbcDataSourceTest.java ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/21805/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21805/1//COMMIT_MSG@18 PS1, Line 18: data source APIs. mention how do you run the unit-test after your fixing http://gerrit.cloudera.org:8080/#/c/21805/1/fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java File fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java: http://gerrit.cloudera.org:8080/#/c/21805/1/fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java@346 PS1, Line 346: props.put("maxTotal", "3"); : props.put("maxIdle", "3"); : props.put("minIdle", "0"); : props.put("maxWaitMillis", "10000"); dbcp_max_conn_pool_size, dbcp_max_wait_millis_for_conn and dbcp_data_source_idle_timeout_s are defined in be/src/service/frontend.cc with default values. Use same default values here if those values could not be passed from backend. http://gerrit.cloudera.org:8080/#/c/21805/1/java/jamm-prefix/src/jamm File java/jamm-prefix/src/jamm: http://gerrit.cloudera.org:8080/#/c/21805/1/java/jamm-prefix/src/jamm@1 PS1, Line 1: Subproject commit 49c3e691c43a39ddaccaf19839ef316807009377 why do you need to add this file? http://gerrit.cloudera.org:8080/#/c/21805/1/testdata/bin/create-ext-data-source-table.sql File testdata/bin/create-ext-data-source-table.sql: http://gerrit.cloudera.org:8080/#/c/21805/1/testdata/bin/create-ext-data-source-table.sql@31 PS1, Line 31: id INT, unnecessary change -- To view, visit http://gerrit.cloudera.org:8080/21805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie07173d256d73c88f5a6c041f087db16b6ff3127 Gerrit-Change-Number: 21805 Gerrit-PatchSet: 1 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 03 Oct 2024 21:59:59 +0000 Gerrit-HasComments: Yes
