Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21729 )
Change subject: IMPALA-13185: Include runtime filter source in key ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/21729/5/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/21729/5/fe/src/main/java/org/apache/impala/planner/PlanNode.java@544 PS5, Line 544: msg.addToRuntime_filters(filter.toThrift(serialCtx)); > The other option is to pass in this PlanNode to this toThrift() call separa I played with that and had some problems. I'll revisit it. http://gerrit.cloudera.org:8080/#/c/21729/5/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/21729/5/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@403 PS5, Line 403: if (serialCtx.includeRFTarget(target.node)) { : // Only serialize the relevant target PlanNode when using tuple caching. > Nit: Can we add a bit more to the comment say that we're skipping runtime f I'm not clear what context is missing. This section doesn't skip runtime filters that don't target the plan node, just targets that aren't the target plan node; which is what the comment already says. -- To view, visit http://gerrit.cloudera.org:8080/21729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0077964be5acdb588d76251a6a39e57a0f42bb5a Gerrit-Change-Number: 21729 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 23 Sep 2024 21:31:15 +0000 Gerrit-HasComments: Yes
