Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21729 )

Change subject: IMPALA-13185: Include runtime filter source in key
......................................................................


Patch Set 6:

(6 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python2 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with virtualenv installed.

http://gerrit.cloudera.org:8080/#/c/21729/6/tests/custom_cluster/test_tuple_cache.py
File tests/custom_cluster/test_tuple_cache.py:

http://gerrit.cloudera.org:8080/#/c/21729/6/tests/custom_cluster/test_tuple_cache.py@30
PS6, Line 30: =
flake8: E225 missing whitespace around operator


http://gerrit.cloudera.org:8080/#/c/21729/6/tests/custom_cluster/test_tuple_cache.py@31
PS6, Line 31: =
flake8: E225 missing whitespace around operator


http://gerrit.cloudera.org:8080/#/c/21729/6/tests/custom_cluster/test_tuple_cache.py@32
PS6, Line 32: =
flake8: E225 missing whitespace around operator


http://gerrit.cloudera.org:8080/#/c/21729/6/tests/custom_cluster/test_tuple_cache.py@34
PS6, Line 34: =
flake8: E225 missing whitespace around operator


http://gerrit.cloudera.org:8080/#/c/21729/6/tests/custom_cluster/test_tuple_cache.py@46
PS6, Line 46: def assertCounter(profile, key, val, num_matches):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/21729/6/tests/custom_cluster/test_tuple_cache.py@52
PS6, Line 52: def assertCounters(profile, num_hits, num_halted, num_skipped, 
num_matches=1):
flake8: E302 expected 2 blank lines, found 1



--
To view, visit http://gerrit.cloudera.org:8080/21729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0077964be5acdb588d76251a6a39e57a0f42bb5a
Gerrit-Change-Number: 21729
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Wed, 25 Sep 2024 23:22:17 +0000
Gerrit-HasComments: Yes

Reply via email to