Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21729 )
Change subject: IMPALA-13185: Include runtime filter source in key ...................................................................... Patch Set 2: (1 comment) We can use the TupleCacheTest frontend test to add some scenarios that test eligibility (e.g. a Kudu table on the build side). We can also use that to test that to test SQLs to make sure they are different. It currently uses num_nodes=1 and doesn't have exchanges, but we could loosen that to have plans with exchanges. http://gerrit.cloudera.org:8080/#/c/21729/2/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/21729/2/fe/src/main/java/org/apache/impala/planner/PlanNode.java@1353 PS2, Line 1353: PlanNode build = filter.getSrc().getBuildNode(); > We already incorporate the Thrift representation of RuntimeFilter at https: Oh, right, that should have that information. I think we'll want to modify the RuntimeFilter toThrift() code to take in the ThriftSerializationCtx. The expressions would use SlotRefs and we want the slot ids to be translated. We may want to mask out certain things as well. -- To view, visit http://gerrit.cloudera.org:8080/21729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0077964be5acdb588d76251a6a39e57a0f42bb5a Gerrit-Change-Number: 21729 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 29 Aug 2024 17:05:34 +0000 Gerrit-HasComments: Yes
