Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21616 )
Change subject: IMPALA-12345: Add user quotas to Admission Control ...................................................................... Patch Set 6: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21616/6/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java File fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java: http://gerrit.cloudera.org:8080/#/c/21616/6/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java@21 PS6, Line 21: import static org.apache.impala.yarn.server.resourcemanager.scheduler.fair.AllocationFileLoaderService.addQueryLimits; line too long (118 > 90) http://gerrit.cloudera.org:8080/#/c/21616/6/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java@412 PS6, Line 412: * Call doQueryLimitParsing() and check that it threw an exception, and that the exception line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21616/6/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java@418 PS6, Line 418: Assert.fail("did not get expected exception, with expected message " + expectedError); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21616/6/java/yarn-extras/src/main/java/org/apache/impala/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java File java/yarn-extras/src/main/java/org/apache/impala/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java: http://gerrit.cloudera.org:8080/#/c/21616/6/java/yarn-extras/src/main/java/org/apache/impala/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java@208 PS6, Line 208: Map<String, Map<String, Integer>> limitsMap, String tagName) line too long (96 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21616 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c33f3f2427db57fb9b6c593a4b22d5029549b41 Gerrit-Change-Number: 21616 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 30 Aug 2024 22:14:55 +0000 Gerrit-HasComments: Yes
