Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21616 )
Change subject: IMPALA-12345: Add user quotas to Admission Control ...................................................................... Patch Set 8: (4 comments) Need to resolve rebase conflicts. I don't see specific issues, but I'll want to spend some more time on this. http://gerrit.cloudera.org:8080/#/c/21616/7/be/src/scheduling/admission-controller.h File be/src/scheduling/admission-controller.h: http://gerrit.cloudera.org:8080/#/c/21616/7/be/src/scheduling/admission-controller.h@558 PS7, Line 558: int64_t increment(const std::string& key); > Done Ack http://gerrit.cloudera.org:8080/#/c/21616/7/fe/src/main/java/org/apache/impala/util/JniRequestPoolService.java File fe/src/main/java/org/apache/impala/util/JniRequestPoolService.java: http://gerrit.cloudera.org:8080/#/c/21616/7/fe/src/main/java/org/apache/impala/util/JniRequestPoolService.java@62 PS7, Line 62: private static final Configuration CONF = new Configuration(); > Yes this was copy and paste without thought. Ack http://gerrit.cloudera.org:8080/#/c/21616/7/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java File fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java: http://gerrit.cloudera.org:8080/#/c/21616/7/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java@390 PS7, Line 390: * Parse a snippet of xml, and then call addQueryLimits() on the root element. > Done Ack http://gerrit.cloudera.org:8080/#/c/21616/7/fe/src/test/resources/fair-scheduler-test.xml File fe/src/test/resources/fair-scheduler-test.xml: http://gerrit.cloudera.org:8080/#/c/21616/7/fe/src/test/resources/fair-scheduler-test.xml@40 PS7, Line 40: <user> userG </user> > yes, added a comment to clarify. Ack -- To view, visit http://gerrit.cloudera.org:8080/21616 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c33f3f2427db57fb9b6c593a4b22d5029549b41 Gerrit-Change-Number: 21616 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 23 Sep 2024 21:21:11 +0000 Gerrit-HasComments: Yes
