Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21616 )
Change subject: IMPALA-12345: Add user quotas to Admission Control ...................................................................... Patch Set 4: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21616/4/be/src/scheduling/request-pool-service.cc File be/src/scheduling/request-pool-service.cc: http://gerrit.cloudera.org:8080/#/c/21616/4/be/src/scheduling/request-pool-service.cc@215 PS4, Line 215: return JniUtil::CallJniMethod(jni_request_pool_service_, get_hadoop_groups_id_, request, response); line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/21616/4/fe/src/main/java/org/apache/impala/util/JniRequestPoolService.java File fe/src/main/java/org/apache/impala/util/JniRequestPoolService.java: http://gerrit.cloudera.org:8080/#/c/21616/4/fe/src/main/java/org/apache/impala/util/JniRequestPoolService.java@74 PS4, Line 74: final String fsAllocationPath, final String sitePath, boolean isBackendTest) throws ImpalaException { line too long (107 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21616 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c33f3f2427db57fb9b6c593a4b22d5029549b41 Gerrit-Change-Number: 21616 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 30 Aug 2024 00:10:06 +0000 Gerrit-HasComments: Yes
