Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21699 )
Change subject: IMPALA-13313: Fix ExpireQueries deadlock ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/21699/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21699/1//COMMIT_MSG@12 PS1, Line 12: ver::ExpireQueries, where it needs to acquire the : query_expiration_lo > Can you mention where this call path is? ImpalaServer::ExpireQueries()? Done http://gerrit.cloudera.org:8080/#/c/21699/1//COMMIT_MSG@18 PS1, Line 18: When the deadlock occurs, SetQueryInFlight holds a session_state->lock : and tries to acquire q > This is the bad locking order, right? I've tried to make that sentence clearer. It identified what locks are held when the deadlock occurs. -- To view, visit http://gerrit.cloudera.org:8080/21699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fce4103f6eeb7e9a4320ba1da817cab81071ba3 Gerrit-Change-Number: 21699 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 21 Aug 2024 00:10:39 +0000 Gerrit-HasComments: Yes
