Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21699 )
Change subject: IMPALA-13313: Fix ExpireQueries deadlock ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21699/1/tests/custom_cluster/test_query_expiration.py File tests/custom_cluster/test_query_expiration.py: http://gerrit.cloudera.org:8080/#/c/21699/1/tests/custom_cluster/test_query_expiration.py@308 PS1, Line 308: def test_query_expiration_no_deadlock(self): : """Confirm that queries do not deadlock when one is expiring while another starts.""" : impalad = self.cluster.get_first_impalad() : num_expired = impalad.service.get_metric_value('impala-server.num-queries-expired') : : handle = self.execute_query_async("SELECT SLEEP(1000000)", : {'query_timeout_s': '1', 'debug_action': 'EXPIRE_INACTIVE_QUERY:SLEEP@3000'}) : : before = time() : : # Prior to fixing IMPALA-13313, this query would enter a deadlock with the expiration : # for the previous query, and both would be unable to finish. : result = self.execute_query("SELECT 1", { : 'query_timeout_s': '10', : 'debug_action': 'SET_QUERY_INFLIGHT_EXPIRATION:SLEEP@5000'}) : assert result.success : : impalad.service.wait_for_metric_value('impala-server.num-queries-expired', : num_expired + 1) : : assert time() - before < 10 : > Oh yeah, I'll add that so it's clearer why this test exists. Done -- To view, visit http://gerrit.cloudera.org:8080/21699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fce4103f6eeb7e9a4320ba1da817cab81071ba3 Gerrit-Change-Number: 21699 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 20 Aug 2024 23:45:27 +0000 Gerrit-HasComments: Yes
