Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21699 )
Change subject: IMPALA-13313: Fix ExpireQueries deadlock ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Thanks Michael so much for the quick fix http://gerrit.cloudera.org:8080/#/c/21699/1/tests/custom_cluster/test_query_expiration.py File tests/custom_cluster/test_query_expiration.py: http://gerrit.cloudera.org:8080/#/c/21699/1/tests/custom_cluster/test_query_expiration.py@308 PS1, Line 308: def test_query_expiration_no_deadlock(self): nit. could we add a comment here to indicate that this is for regression testing for IMPALA-13313, like https://github.com/apache/impala/blob/9848cd84be6ed07fe542b82d2e2628e658690621/tests/custom_cluster/test_admission_controller.py#L495 -- To view, visit http://gerrit.cloudera.org:8080/21699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fce4103f6eeb7e9a4320ba1da817cab81071ba3 Gerrit-Change-Number: 21699 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 20 Aug 2024 23:48:07 +0000 Gerrit-HasComments: Yes
