Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21556 )
Change subject: IMPALA-13182: Support uploading additional jars ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21556/4/docker/daemon_entrypoint.sh File docker/daemon_entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/21556/4/docker/daemon_entrypoint.sh@120 PS4, Line 120: CLASSPATH+=:$jar These additional JARs definitely need to be appended to the end of the classpath. What happens if the CLASSPATH already ends with a colon? This code will add a second consecutive colon in the classpath. I'm fairly certain that will not cause issues, but I don't know for sure. Was that scenario tested? -- To view, visit http://gerrit.cloudera.org:8080/21556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica5fa4c0cd1a5c938f331f3a4bba85d4910db90e Gerrit-Change-Number: 21556 Gerrit-PatchSet: 4 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Wed, 14 Aug 2024 15:05:14 +0000 Gerrit-HasComments: Yes
