gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/21556 )
Change subject: IMPALA-13182: Support uploading additional jars ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21556/3/docker/daemon_entrypoint.sh File docker/daemon_entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/21556/3/docker/daemon_entrypoint.sh@118 PS3, Line 118: CLASSPATH+=:/opt/impala/aux-jars > The docs I am finding state that either the specific JARs must be added to so the /* is mostly an optional wildcard. I tested with CLASSPATH += :/opt/impala/aux-jars/ and it works i.e. picked up the new jar that was downloaded in that directory. http://gerrit.cloudera.org:8080/#/c/21556/3/docker/daemon_entrypoint.sh@118 PS3, Line 118: CLASSPATH+=:/opt/impala/aux-jars > There is the potential for a very subtle bug here. The JRE docs state that I will add the validation in the file download script. -- To view, visit http://gerrit.cloudera.org:8080/21556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica5fa4c0cd1a5c938f331f3a4bba85d4910db90e Gerrit-Change-Number: 21556 Gerrit-PatchSet: 3 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Mon, 12 Aug 2024 17:53:52 +0000 Gerrit-HasComments: Yes
