Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21556 )
Change subject: IMPALA-13182: Support uploading additional jars ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21556/3/docker/daemon_entrypoint.sh File docker/daemon_entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/21556/3/docker/daemon_entrypoint.sh@118 PS3, Line 118: CLASSPATH+=:/opt/impala/aux-jars There is the potential for a very subtle bug here. The JRE docs state that, when using wildcards in the classpath, only files with an extension of ".jar" or ".JAR" will be picked up. Given that constraint, we should rename all JAR files to have an extension of ".jar". http://gerrit.cloudera.org:8080/#/c/21556/3/docker/daemon_entrypoint.sh@118 PS3, Line 118: CLASSPATH+=:/opt/impala/aux-jars The docs I am finding state that either the specific JARs must be added to the classpath or else a wildcard must be specified. I don't see any docs stating that specifying a directory on the classpath will cause the JRE to automatically pick up all JARs in the directory. Thus, to comply with existing docs, we should add a "/*" onto the end of this line: CLASSPATH+=:/opt/impala/aux-jars/* https://bugs.openjdk.org/browse/JDK-8220775 https://docs.oracle.com/javase/8/docs/technotes/tools/windows/classpath.html#A1100762 -- To view, visit http://gerrit.cloudera.org:8080/21556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica5fa4c0cd1a5c938f331f3a4bba85d4910db90e Gerrit-Change-Number: 21556 Gerrit-PatchSet: 3 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Tue, 16 Jul 2024 16:00:45 +0000 Gerrit-HasComments: Yes
