Fang-Yu Rao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21645 )

Change subject: IMPALA-13250: [DOCS] Document ENABLED_RUNTIME_FILTER_TYPES 
query option
......................................................................


Patch Set 3:

(1 comment)

Hi all, I have addressed Quanlong's comment on the patch set 2. Let me know if 
there is any other suggestion. Thanks!

http://gerrit.cloudera.org:8080/#/c/21645/2/docs/topics/impala_enabled_runtime_filter_types.xml
File docs/topics/impala_enabled_runtime_filter_types.xml:

http://gerrit.cloudera.org:8080/#/c/21645/2/docs/topics/impala_enabled_runtime_filter_types.xml@69
PS2, Line 69:     <p>
            :       Depending on the scan node type, Planner can schedule 
compatible runtime filter
            :       types as follows.
            :       <ul>
            :         <li>Kudu scan: <codeph>BLOOM</codeph>, 
<codeph>MIN_MAX</codeph></li>
            :         <li>
            :           HDFS scan on Parquet files: <codeph>BLOOM</codeph>, 
<codeph
> Can we move this to impala_common.xml as well? We can slightly modify it to
Thanks Quanlong! I will move this paragraph to impala_common.xml too in the 
next patch.



--
To view, visit http://gerrit.cloudera.org:8080/21645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7a34782bed6f812fedf717d8a076e2706f0bba9
Gerrit-Change-Number: 21645
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Thu, 08 Aug 2024 16:13:43 +0000
Gerrit-HasComments: Yes

Reply via email to