Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21645 )
Change subject: IMPALA-13250: [DOCS] Document ENABLED_RUNTIME_FILTER_TYPES query option ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21645/2/docs/topics/impala_enabled_runtime_filter_types.xml File docs/topics/impala_enabled_runtime_filter_types.xml: http://gerrit.cloudera.org:8080/#/c/21645/2/docs/topics/impala_enabled_runtime_filter_types.xml@69 PS2, Line 69: This is usually the case when running : <codeph>SET ENABLED_RUNTIME_FILTER_TYPES="value1,value2"</codeph> using a JDBC : driver. When using Impala-shell client, the <codeph>SET</codeph> statement is not : executed immediately but query options are updated in the client and applied as : part of the following statement, so no quotes are required for Impala-shell. That : is, we use <codeph>SET ENABLED_RUNTIME_FILTER_TYPES=value1,value2</codeph> when : submitting the query to Impala backend via Impala-shell client. Can we move this to impala_common.xml as well? We can slightly modify it to be more generic: This is usually the case when running SET statement like <codeph>SET ENABLED_RUNTIME_FILTER_TYPES="value1,value2"</codeph> using a JDBC driver. When using Impala-shell client, the <codeph>SET</codeph> statement is not executed immediately but query options are updated in the client and applied as part of the following statement, so no quotes are required for Impala-shell. That is, we use SET statement like <codeph>SET ENABLED_RUNTIME_FILTER_TYPES=value1,value2</codeph> when submitting the query to Impala backend via Impala-shell client. -- To view, visit http://gerrit.cloudera.org:8080/21645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7a34782bed6f812fedf717d8a076e2706f0bba9 Gerrit-Change-Number: 21645 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 08 Aug 2024 02:13:14 +0000 Gerrit-HasComments: Yes
