Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/21645 )
Change subject: IMPALA-13250: [DOCS] Document ENABLED_RUNTIME_FILTER_TYPES query option ...................................................................... Patch Set 2: (2 comments) Hi all, I have revised the patch set 1 according to reviewers' comments. Let me know if there are still additional suggestions. Thanks! http://gerrit.cloudera.org:8080/#/c/21645/1/docs/topics/impala_enabled_runtime_filter_types.xml File docs/topics/impala_enabled_runtime_filter_types.xml: http://gerrit.cloudera.org:8080/#/c/21645/1/docs/topics/impala_enabled_runtime_filter_types.xml@67 PS1, Line 67: <p conref="../shared/impala_common.xml#common/comma_separated_values_blurb"/> > runtime_filter_ids_to_skip is also set with comma-separated values. Thanks Michael and Wenzhe! I will move this paragraph to impala_common.xml in the next patch. On a related note, I found that we don't seem to document the usage of 'runtime_filter_ids_to_skip'. Maybe we could do so in a follow-up JIRA? http://gerrit.cloudera.org:8080/#/c/21645/1/docs/topics/impala_enabled_runtime_filter_types.xml@94 PS1, Line 94: <xref href="impala_runtime_filter_mode.xml#runtime_filter_mode"/> > nit: remove this? Done -- To view, visit http://gerrit.cloudera.org:8080/21645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7a34782bed6f812fedf717d8a076e2706f0bba9 Gerrit-Change-Number: 21645 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 07 Aug 2024 19:31:46 +0000 Gerrit-HasComments: Yes
