Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21516 )
Change subject: IMPALA-13077: Fix selectivity estimation for SEMI JOIN ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/21516/4/testdata/workloads/functional-planner/queries/PlannerTest/implicit-joins.test File testdata/workloads/functional-planner/queries/PlannerTest/implicit-joins.test: http://gerrit.cloudera.org:8080/#/c/21516/4/testdata/workloads/functional-planner/queries/PlannerTest/implicit-joins.test@484 PS4, Line 484: shoul > typo Done http://gerrit.cloudera.org:8080/#/c/21516/4/testdata/workloads/functional-planner/queries/PlannerTest/implicit-joins.test@486 PS4, Line 486: where ss_sold_date_sk=( : select min(d_date_sk) + 1000 from tpcds.date_dim) > I still think that it would be better to test with a table without stats in Patch set 6 add another test case that show cardinality estimate difference before vs after patch. Before patch, no reduction happen at all in the probe side. I can not find a test case against table without stats where probe cardinality changed after this patch, possibly because getSemiJoinCardinality() will skip any eqJoinPredicate predicate entirely upon missing numRows or NDV. -- To view, visit http://gerrit.cloudera.org:8080/21516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c799df535d764c3f87ededef1c48eaa103293a0 Gerrit-Change-Number: 21516 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 26 Jul 2024 15:53:05 +0000 Gerrit-HasComments: Yes
