Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21516 )
Change subject: IMPALA-13077: Fix selectivity estimation for SEMI JOIN ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21516/4/fe/src/main/java/org/apache/impala/planner/JoinNode.java File fe/src/main/java/org/apache/impala/planner/JoinNode.java: http://gerrit.cloudera.org:8080/#/c/21516/4/fe/src/main/java/org/apache/impala/planner/JoinNode.java@777 PS4, Line 777: public static long getNdv(Expr expr) { I found that I can achieve a correct estimate and plan if I make this function call ColumnStats.fromExpr(expr). I'll run a core test to check if that approach is correct. -- To view, visit http://gerrit.cloudera.org:8080/21516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c799df535d764c3f87ededef1c48eaa103293a0 Gerrit-Change-Number: 21516 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 24 Jul 2024 23:41:05 +0000 Gerrit-HasComments: Yes
