Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21516 )
Change subject: IMPALA-13077: Fix selectivity estimation for SEMI JOIN ...................................................................... Patch Set 5: Code-Review+1 (2 comments) I would prefer to add a test that doesn't rely on scalar subqueries, otherwise LGTM http://gerrit.cloudera.org:8080/#/c/21516/4/testdata/workloads/functional-planner/queries/PlannerTest/implicit-joins.test File testdata/workloads/functional-planner/queries/PlannerTest/implicit-joins.test: http://gerrit.cloudera.org:8080/#/c/21516/4/testdata/workloads/functional-planner/queries/PlannerTest/implicit-joins.test@484 PS4, Line 484: shoud typo http://gerrit.cloudera.org:8080/#/c/21516/4/testdata/workloads/functional-planner/queries/PlannerTest/implicit-joins.test@486 PS4, Line 486: where ss_sold_date_sk=( : select min(d_date_sk) + 1000 from tpcds.date_dim) > Changes in patch set 5 managed to pass this new test. I still think that it would be better to test with a table without stats instead of a scalar subquery. -- To view, visit http://gerrit.cloudera.org:8080/21516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c799df535d764c3f87ededef1c48eaa103293a0 Gerrit-Change-Number: 21516 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 26 Jul 2024 10:03:57 +0000 Gerrit-HasComments: Yes
