Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21587 )
Change subject: IMPALA-13115: Add query id to error messages ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/21587/5/be/src/service/child-query.cc File be/src/service/child-query.cc: http://gerrit.cloudera.org:8080/#/c/21587/5/be/src/service/child-query.cc@81 PS5, Line 81: // TODO: Do we need to make query id available to the following HS2_RETURN_IF_ERROR()? Do you have a scenario where it isn't? http://gerrit.cloudera.org:8080/#/c/21587/5/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/21587/5/be/src/service/impala-server.cc@a1258 PS5, Line 1258: If every caller is now required to set this up, please add a note about it to the function comment in impala-server.h. http://gerrit.cloudera.org:8080/#/c/21587/5/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/21587/5/shell/impala_shell.py@708 PS5, Line 708: # '\n' ensures that this is the beginning of the error detail. impala-shell is often used from a pypi release, so it won't necessarily match the server version. Let's preserve the old pattern matching as well. http://gerrit.cloudera.org:8080/#/c/21587/5/tests/custom_cluster/test_sys_db.py File tests/custom_cluster/test_sys_db.py: http://gerrit.cloudera.org:8080/#/c/21587/5/tests/custom_cluster/test_sys_db.py@64 PS5, Line 64: "table '{0}' failed to create but for the wrong reason".format(table_name) we should also print the error e in the assert message -- To view, visit http://gerrit.cloudera.org:8080/21587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67e659681e36162cad1d9684189106f8eedbf092 Gerrit-Change-Number: 21587 Gerrit-PatchSet: 5 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Thu, 25 Jul 2024 17:53:39 +0000 Gerrit-HasComments: Yes
