Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21587 )
Change subject: IMPALA-13115: Add query id to error messages ...................................................................... Patch Set 4: (15 comments) http://gerrit.cloudera.org:8080/#/c/21587/4/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: http://gerrit.cloudera.org:8080/#/c/21587/4/be/src/service/impala-beeswax-server.cc@76 PS4, Line 76: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21587/4/tests/common/test_result_verifier.py File tests/common/test_result_verifier.py: http://gerrit.cloudera.org:8080/#/c/21587/4/tests/common/test_result_verifier.py@810 PS4, Line 810: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/21587/4/tests/common/test_result_verifier.py@810 PS4, Line 810: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21587/4/tests/common/test_result_verifier.py@812 PS4, Line 812: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/21587/4/tests/common/test_result_verifier.py@812 PS4, Line 812: - If a query id is specified in the parameter, it checks if the actual error line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21587/4/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/21587/4/tests/shell/test_shell_commandline.py@280 PS4, Line 280: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/21587/4/tests/shell/test_shell_commandline.py@280 PS4, Line 280: stderr_get_first_error_msg(result.stderr), line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21587/4/tests/shell/test_shell_commandline.py@293 PS4, Line 293: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/21587/4/tests/shell/test_shell_commandline.py@293 PS4, Line 293: stderr_get_first_error_msg(result.stderr), line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21587/4/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/21587/4/tests/shell/test_shell_interactive.py@52 PS4, Line 52: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/21587/4/tests/shell/test_shell_interactive.py@52 PS4, Line 52: create_impala_shell_executable_dimension, get_impala_shell_executable, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21587/4/tests/shell/test_shell_interactive.py@1148 PS4, Line 1148: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/21587/4/tests/shell/test_shell_interactive.py@1148 PS4, Line 1148: stderr_get_first_error_msg(result.stderr), line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21587/4/tests/shell/test_shell_interactive.py@1161 PS4, Line 1161: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/21587/4/tests/shell/test_shell_interactive.py@1161 PS4, Line 1161: stderr_get_first_error_msg(result.stderr), line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/21587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67e659681e36162cad1d9684189106f8eedbf092 Gerrit-Change-Number: 21587 Gerrit-PatchSet: 4 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Thu, 25 Jul 2024 02:52:26 +0000 Gerrit-HasComments: Yes
