Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21587 )
Change subject: IMPALA-13115: Add query id to error messages ...................................................................... Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/21587/5/be/src/service/child-query.cc File be/src/service/child-query.cc: http://gerrit.cloudera.org:8080/#/c/21587/5/be/src/service/child-query.cc@81 PS5, Line 81: TGetResultSetMetadataReq meta_req; > Thank you! After digging into the code, I found that errors in this functio Done http://gerrit.cloudera.org:8080/#/c/21587/5/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/21587/5/be/src/service/impala-server.cc@a1258 PS5, Line 1258: > Thank you! It is not required by the caller of `Execute()` to set this up, I'm pretty sure it is needed for Execute in case we produce a minidump. http://gerrit.cloudera.org:8080/#/c/21587/5/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/21587/5/shell/impala_shell.py@708 PS5, Line 708: if err_msg in ['ERROR: Cancelled', 'ERROR: Invalid or unknown query handle'] or \ > Thank you! Indeed compatibility is very important. I added back the old pat Done http://gerrit.cloudera.org:8080/#/c/21587/7/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/21587/7/shell/impala_shell.py@810 PS7, Line 810: import re nit: we 'import re' at the top of the file, so I think this could be safely removed. http://gerrit.cloudera.org:8080/#/c/21587/5/tests/custom_cluster/test_sys_db.py File tests/custom_cluster/test_sys_db.py: http://gerrit.cloudera.org:8080/#/c/21587/5/tests/custom_cluster/test_sys_db.py@64 PS5, Line 64: "table '{0}' failed to create but for the wrong reason:\n{1}\n" \ > Thank you! Added error e to the assertion message. Done -- To view, visit http://gerrit.cloudera.org:8080/21587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67e659681e36162cad1d9684189106f8eedbf092 Gerrit-Change-Number: 21587 Gerrit-PatchSet: 7 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Fri, 26 Jul 2024 17:57:43 +0000 Gerrit-HasComments: Yes
