Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21437 )
Change subject: IMPALA-12277: Fix NullPointerException for partitioned inserts when partition list is stale ...................................................................... Patch Set 19: (2 comments) http://gerrit.cloudera.org:8080/#/c/21437/19/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/21437/19/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7297 PS19, Line 7297: partsToCreate.size() == 0 > nit: Let's change this to partsToCreate.isEmpty() Ack http://gerrit.cloudera.org:8080/#/c/21437/18/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/21437/18/tests/custom_cluster/test_events_custom_configs.py@1280 PS18, Line 1280: 0 > Ah, could you share where it's modified and add a comment if possible? HdfsTable#updatePartitionsFromHms() may modify this HashSet if the partitions already exist in the metastore but not in Impala's cache. Also, I added a comment regarding the pass-by-value variable. -- To view, visit http://gerrit.cloudera.org:8080/21437 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide8f1f6bf017e9a040b53bb5d5291ff2ea3e0d18 Gerrit-Change-Number: 21437 Gerrit-PatchSet: 19 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Mon, 22 Jul 2024 18:57:25 +0000 Gerrit-HasComments: Yes
