Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21437 )
Change subject: IMPALA-12277: Fix NullPointerException for partitioned inserts when partition list is stale ...................................................................... Patch Set 18: (7 comments) http://gerrit.cloudera.org:8080/#/c/21437/17//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21437/17//COMMIT_MSG@18 PS17, Line 18: the target par > nit: we are not loading all the partitions. To be specifit, "the target par Ack http://gerrit.cloudera.org:8080/#/c/21437/17//COMMIT_MSG@19 PS17, Line 19: f state > nit: need a space Ack http://gerrit.cloudera.org:8080/#/c/21437/17/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/21437/17/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1243 PS17, Line 1243: > nit: let's keep one method call in one line since they are more like an sta Ack http://gerrit.cloudera.org:8080/#/c/21437/17/fe/src/main/java/org/apache/impala/catalog/HdfsTableLoadParams.java File fe/src/main/java/org/apache/impala/catalog/HdfsTableLoadParams.java: http://gerrit.cloudera.org:8080/#/c/21437/17/fe/src/main/java/org/apache/impala/catalog/HdfsTableLoadParams.java@76 PS17, Line 76: isLoadPartition > nit: can we use a better name? getFileMetadata() sounds like getting the fi Ack http://gerrit.cloudera.org:8080/#/c/21437/16/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/21437/16/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7260 PS16, Line 7260: tadata(true) > > I wanted to pass by the value 'partsToCreate' so that the original value Ack http://gerrit.cloudera.org:8080/#/c/21437/17/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/21437/17/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7260 PS17, Line 7260: .reuseMetadata(true) : .setLoadPartitionFileMetadata(false) : .setLoadTableSchema(true) : .setRefreshUpdatedPartitions(true) : .setPartitionsToUpdate(partsToCreate) > nit: it'd be more clear to put one method at a line. Ack http://gerrit.cloudera.org:8080/#/c/21437/17/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/21437/17/tests/custom_cluster/test_events_custom_configs.py@1295 PS17, Line 1295: .format(unique_database, test_table)) > Can we add another new and non-empty partition in Hive? Just want to see if Ack -- To view, visit http://gerrit.cloudera.org:8080/21437 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide8f1f6bf017e9a040b53bb5d5291ff2ea3e0d18 Gerrit-Change-Number: 21437 Gerrit-PatchSet: 18 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 16 Jul 2024 00:48:20 +0000 Gerrit-HasComments: Yes
