Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21437 )
Change subject: IMPALA-12277: Fix NullPointerException for partitioned inserts when partition list is stale ...................................................................... Patch Set 18: (2 comments) http://gerrit.cloudera.org:8080/#/c/21437/18/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/21437/18/tests/custom_cluster/test_events_custom_configs.py@1280 PS18, Line 1280: 5 In my local env, Hive takes 20+ seconds to execute the 2 AlterTable commands and the INSERT command. We need their events being processed before Impala executes the INSERT statement. So this should be set to 20+ or 0 to make sure catalogd has stale partition list. EDIT: when I change this to 0 or 30, the test failed by missing the partition of year=2023. Could you look into this? assert results.data == ["2024", "2023", "2022", "2021"] E assert ['2024', '2022', '2021'] == ['2024', '2023', '2022', '2021'] http://gerrit.cloudera.org:8080/#/c/21437/18/tests/custom_cluster/test_events_custom_configs.py@1281 PS18, Line 1281: def test_ep_delay_metadata_reload_for_insert(self, unique_database): Add @SkipIfFS.hive since we need HiveServer2 to run the INSERT. The test will fail in jobs that don't launch HiveServer2. -- To view, visit http://gerrit.cloudera.org:8080/21437 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide8f1f6bf017e9a040b53bb5d5291ff2ea3e0d18 Gerrit-Change-Number: 21437 Gerrit-PatchSet: 18 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 16 Jul 2024 07:00:03 +0000 Gerrit-HasComments: Yes
