Xiang Yang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21297 )

Change subject: IMPALA-13001: Support graceful and force shutdown for impala.sh.
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21297/1/package/bin/impala.sh
File package/bin/impala.sh:

http://gerrit.cloudera.org:8080/#/c/21297/1/package/bin/impala.sh@87
PS1, Line 87: counts=20 period=2
> I think this is not very reasonable. The purpose of a graceful shutdown is
Done


http://gerrit.cloudera.org:8080/#/c/21297/2/package/bin/impala.sh
File package/bin/impala.sh:

http://gerrit.cloudera.org:8080/#/c/21297/2/package/bin/impala.sh@261
PS2, Line 261:     -c:
> Oh yes, but I think it would be even better if restart also supported -f/-g
Done



--
To view, visit http://gerrit.cloudera.org:8080/21297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7743234952ba6b12694ecc68a920d59fea0d4ba
Gerrit-Change-Number: 21297
Gerrit-PatchSet: 4
Gerrit-Owner: Xiang Yang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Xiang Yang <[email protected]>
Gerrit-Reviewer: Zihao Ye <[email protected]>
Gerrit-Comment-Date: Wed, 05 Jun 2024 16:10:08 +0000
Gerrit-HasComments: Yes

Reply via email to